Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.1 #6

Merged
merged 4 commits into from
May 22, 2024
Merged

Wagtail 6.1 #6

merged 4 commits into from
May 22, 2024

Conversation

…ister_user_listing_buttons hook was updated to accept a request_user argument instead of context
@katdom13 katdom13 self-assigned this May 14, 2024
@katdom13 katdom13 requested a review from nickmoreton May 14, 2024 08:16
Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katdom13

I noticed the + symbol missing from the button here:

<a href="{% url 'wagtail_2fa_device_new' %}" class="button bicolor icon icon-plus">{% trans 'New device' %}</a>

I tried this locally and it seems to work OK

<a href="{% url 'wagtail_2fa_device_new' %}" class="button bicolor button--icon">
                <span class="icon-wrapper"><svg class="icon icon-plus icon" aria-hidden="true"><use href="#icon-plus"></use></svg></span>
                {% trans 'New device' %}
            </a>

@katdom13
Copy link
Author

{% trans 'New device' %}

Hi @nickmoreton ,
Thank you for this. Applied the fix:
image

@katdom13 katdom13 requested a review from nickmoreton May 21, 2024 08:14
Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katdom13 Looks good

@katdom13 katdom13 merged commit 535cf5f into master May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants